Skip to content

Instantly share code, notes, and snippets.

@Firoz-Thakur
Forked from SuryaPratapK/Next greater element
Created April 25, 2020 09:36
Show Gist options
  • Save Firoz-Thakur/0f58f6915a83817248b8167ac53b03f1 to your computer and use it in GitHub Desktop.
Save Firoz-Thakur/0f58f6915a83817248b8167ac53b03f1 to your computer and use it in GitHub Desktop.
// A Stack based C++ program to find next
// greater element for all array elements.
#include <bits/stdc++.h>
using namespace std;
/* prints element and NGE pair for all
elements of arr[] of size n */
void printNGE(int arr[], int n) {
stack < int > s;
/* push the first element to stack */
s.push(arr[0]);
// iterate for rest of the elements
for (int i = 1; i < n; i++) {
if (s.empty()) {
s.push(arr[i]);
continue;
}
/* if stack is not empty, then
pop an element from stack.
If the popped element is smaller
than next, then
a) print the pair
b) keep popping while elements are
smaller and stack is not empty */
while (s.empty() == false && s.top() < arr[i])
{
cout << s.top() << " --> " << arr[i] << endl;
s.pop();
}
/* push next to stack so that we can find
next greater for it */
s.push(arr[i]);
}
/* After iterating over the loop, the remaining
elements in stack do not have the next greater
element, so print -1 for them */
while (s.empty() == false) {
cout << s.top() << " --> " << -1 << endl;
s.pop();
}
}
/* Driver program to test above functions */
int main() {
int arr[] = {11, 13, 21, 3};
int n = sizeof(arr) / sizeof(arr[0]);
printNGE(arr, n);
return 0;
}
@Firoz-Thakur
Copy link
Author

your code will not work for the test case :

7 81 4

correction 👍

void nextlargest_element(long long int ar[],long long int n)
{

stack <long long int> st;
st.push(0);
//int t=0;
long long int x[n];
for(long long int i=1;i<n;i++)
{
    if(st.empty())
     st.push(i);
    
    while( !st.empty() && ar[st.top()]<=ar[i])
     {
         x[st.top()]=ar[i];
         st.pop();
     }
     st.push(i);
}
while(!st.empty())
{
    x[st.top()]=-1;
    st.pop();
}

for(int i=0;i<n;i++)
{
cout<<x[i]<<" ";
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment