Created
May 22, 2025 23:47
-
-
Save aaron-prindle/5a47f8b64a5ec8cff870b5bc12590216 to your computer and use it in GitHub Desktop.
add // +k8s:minimum=600 to certificates.k8s.io/v1/CertificateSigningRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprindle@aprindle-ssd ~/validation-gen [my-validation-gen_enable-csr-view]git diff | |
diff --git a/pkg/apis/certificates/validation/validation_test.go b/pkg/apis/certificates/validation/validation_test.go | |
index a54aa9adf46..25fa6a7d367 100644 | |
--- a/pkg/apis/certificates/validation/validation_test.go | |
+++ b/pkg/apis/certificates/validation/validation_test.go | |
@@ -274,7 +274,7 @@ func TestValidateCertificateSigningRequestCreate(t *testing.T) { | |
}, | |
}, | |
errs: field.ErrorList{ | |
- field.Invalid(specPath.Child("expirationSeconds"), int32(-1), "may not specify a duration less than 600 seconds (10 minutes)"), | |
+ field.Invalid(specPath.Child("expirationSeconds"), int32(-1), "may not specify a duration less than 600 seconds (10 minutes)").MarkCoveredByDeclarative(), | |
}, | |
}, | |
"zero duration": { | |
diff --git a/staging/src/k8s.io/api/certificates/v1/types.go b/staging/src/k8s.io/api/certificates/v1/types.go | |
index ba8009840d8..12791550962 100644 | |
--- a/staging/src/k8s.io/api/certificates/v1/types.go | |
+++ b/staging/src/k8s.io/api/certificates/v1/types.go | |
@@ -105,6 +105,7 @@ type CertificateSigningRequestSpec struct { | |
// The minimum valid value for expirationSeconds is 600, i.e. 10 minutes. | |
// | |
// +optional | |
+ // +k8s:minimum=600 | |
ExpirationSeconds *int32 `json:"expirationSeconds,omitempty" protobuf:"varint,8,opt,name=expirationSeconds"` | |
// usages specifies a set of key usages requested in the issued certificate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment