Skip to content

Instantly share code, notes, and snippets.

@anyone-can-test

anyone-can-test/jenkins junit plugin에 기능 추가하기.md

Last active November 26, 2015 06:36
Show Gist options
  • Save anyone-can-test/0e609b911638d688c4c5 to your computer and use it in GitHub Desktop.
Save anyone-can-test/0e609b911638d688c4c5 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
jenkins junit plugin에 기능 추가하기.md

jenkinsci/junit-plugin#29

Pull Request 하기

참고: https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories

  1. new feature, bug 인 경우 우선 JIRA에 등록한다.
  1. cherry-pick을 이용하여 commits 다시 정리한다. 하나의 commit으로 만든다. http://stackoverflow.com/questions/14034718/include-only-specific-commits-in-a-pull-request http://makandracards.com/makandra/527-squash-several-git-commits-into-a-single-commit
  • Create a new branch based on upstream/master
  • cherry-pick the relevant commits from your brach Topic2 (into the new branch)
  • Create a pull request from this new branch.

  1. Refer to the ticket in your commit message by using the notation [JENKINS-1234]

  2. pull request 를 하면 검증이 자동으로 시작된다.

  1. 위 검증에서 테스트 실패함 내가 만든 코드와 영향이 있는 건가????

  2. feedback

  • hudson.util.EditDistance should be used instead of external dependency.(완료)
  • remove Unused (완료)
  • Please, fix the indentation. (완료)
    • .java, .jelly
  • HudsonTestCase is deprecated, use JenkinsRule instead.
  • The failures are related.

  1. 수정 후 나의 repository에 push하면 자동으로 pull request 와 연결됨 (jenkins ci 동작함, https://jenkins.ci.cloudbees.com/job/plugins/job/junit-plugin/122/)

  2. feedback (2015.11.26)

  • GroupByError.java, NIT: @since TODO
  • GroupByError.java, Would be great to make it configurable. Just a topic for the further RFE

To Do

  1. 실패한 test 목록에 test message (one line) 컬럼 추가하기 (완료)

  2. 유사 error message 기준으로 실패한 테스트 목록 보기 (완료)

  • 별도 페이지 하나 만들기

  1. similiarity 계산을 위한 값을 사용자 입력으로 받기

  2. unit test 작성 (완료)

  3. 리팩토링: rename (완료) Class

  • Analyze -> GroupCaseResultsByErrorMessage -> GroupFailedTests -> AnalyzeFailedTests -> GroupByErrorMessage

    • resource/.../Analyze -> GroupByError

  • ErrorMessageResult -> CaseResultGroupByErrorMessage GroupResultByErrorMessage

                      GroupedCaseResults
  1. MIT 라이선스 적용 (완료)

기타

  • LGTM: Looks Good To ME
  • WDYT: What Do You Think?
  • RFE: Request For Enhencement
  • NIT: minor 개선
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment