Skip to content

Instantly share code, notes, and snippets.

@bhackett1024
Created January 17, 2020 20:29
Show Gist options
  • Save bhackett1024/ad63a7bcfa22dc253743d83f3e136feb to your computer and use it in GitHub Desktop.
Save bhackett1024/ad63a7bcfa22dc253743d83f3e136feb to your computer and use it in GitHub Desktop.
diff --git a/devtools/client/debugger/src/reducers/pause.js b/devtools/client/debugger/src/reducers/pause.js
--- a/devtools/client/debugger/src/reducers/pause.js
+++ b/devtools/client/debugger/src/reducers/pause.js
@@ -30,15 +30,9 @@ import type {
ThreadContext,
Previews,
SourceLocation,
- ExecutionPoint,
} from "../types";
-export type Command =
- | null
- | "stepOver"
- | "stepIn"
- | "stepOut"
- | "resume";
+export type Command = null | "stepOver" | "stepIn" | "stepOut" | "resume";
// Pause state associated with an individual thread.
type ThreadPauseState = {
diff --git a/devtools/client/webconsole/reducers/messages.js b/devtools/client/webconsole/reducers/messages.js
--- a/devtools/client/webconsole/reducers/messages.js
+++ b/devtools/client/webconsole/reducers/messages.js
@@ -66,8 +66,6 @@ const {
processNetworkUpdates,
} = require("devtools/client/netmonitor/src/utils/request-utils");
-const maxNumber = 100000;
-
const MessageState = overrides =>
Object.freeze(
Object.assign(
diff --git a/devtools/server/actors/highlighters.js b/devtools/server/actors/highlighters.js
--- a/devtools/server/actors/highlighters.js
+++ b/devtools/server/actors/highlighters.js
@@ -10,7 +10,6 @@ const ChromeUtils = require("ChromeUtils
const EventEmitter = require("devtools/shared/event-emitter");
const protocol = require("devtools/shared/protocol");
const Services = require("Services");
-const ReplayInspector = require("devtools/server/actors/replay/inspector");
const {
highlighterSpec,
customHighlighterSpec,
diff --git a/devtools/server/actors/highlighters/auto-refresh.js b/devtools/server/actors/highlighters/auto-refresh.js
--- a/devtools/server/actors/highlighters/auto-refresh.js
+++ b/devtools/server/actors/highlighters/auto-refresh.js
@@ -6,7 +6,6 @@
const { Cu } = require("chrome");
const EventEmitter = require("devtools/shared/event-emitter");
-const ReplayInspector = require("devtools/server/actors/replay/inspector");
const {
isNodeValid,
} = require("devtools/server/actors/highlighters/utils/markup");
diff --git a/devtools/server/actors/inspector/event-collector.js b/devtools/server/actors/inspector/event-collector.js
--- a/devtools/server/actors/inspector/event-collector.js
+++ b/devtools/server/actors/inspector/event-collector.js
@@ -16,7 +16,6 @@ const {
isNativeAnonymous,
} = require("devtools/shared/layout/utils");
const Debugger = require("Debugger");
-const ReplayInspector = require("devtools/server/actors/replay/inspector");
const {
EXCLUDED_LISTENER,
} = require("devtools/server/actors/inspector/constants");
@@ -914,7 +913,7 @@ class EventCollector {
// their global object can vary e.g. resource:// URLs on a video control. If
// we don't do this then all chrome listeners simply display "native code."
globalDO = dbg.addDebuggee(global);
- const listenerDO = globalDO.makeDebuggeeValue(handler);
+ let listenerDO = globalDO.makeDebuggeeValue(handler);
const { normalizeListener } = listener;
diff --git a/devtools/server/actors/inspector/inspector.js b/devtools/server/actors/inspector/inspector.js
--- a/devtools/server/actors/inspector/inspector.js
+++ b/devtools/server/actors/inspector/inspector.js
@@ -54,7 +54,6 @@ const Services = require("Services");
const protocol = require("devtools/shared/protocol");
const { LongStringActor } = require("devtools/server/actors/string");
const defer = require("devtools/shared/defer");
-const ReplayInspector = require("devtools/server/actors/replay/inspector");
const { inspectorSpec } = require("devtools/shared/specs/inspector");
diff --git a/devtools/server/actors/inspector/walker.js b/devtools/server/actors/inspector/walker.js
--- a/devtools/server/actors/inspector/walker.js
+++ b/devtools/server/actors/inspector/walker.js
@@ -11,7 +11,6 @@ const protocol = require("devtools/share
const { walkerSpec } = require("devtools/shared/specs/walker");
const { LongStringActor } = require("devtools/server/actors/string");
const InspectorUtils = require("InspectorUtils");
-const ReplayInspector = require("devtools/server/actors/replay/inspector");
const {
EXCLUDED_LISTENER,
} = require("devtools/server/actors/inspector/constants");
diff --git a/devtools/server/actors/stylesheets.js b/devtools/server/actors/stylesheets.js
--- a/devtools/server/actors/stylesheets.js
+++ b/devtools/server/actors/stylesheets.js
@@ -39,16 +39,6 @@ loader.lazyRequireGetter(
"devtools/shared/layout/utils",
true
);
-loader.lazyRequireGetter(
- this,
- "ReplayDebugger",
- "devtools/server/actors/replay/debugger"
-);
-loader.lazyRequireGetter(
- this,
- "ReplayInspector",
- "devtools/server/actors/replay/inspector"
-);
var TRANSITION_PSEUDO_CLASS = ":-moz-styleeditor-transitioning";
var TRANSITION_DURATION_MS = 500;
diff --git a/devtools/server/actors/thread.js b/devtools/server/actors/thread.js
--- a/devtools/server/actors/thread.js
+++ b/devtools/server/actors/thread.js
@@ -54,7 +54,6 @@ loader.lazyRequireGetter(
"devtools/server/actors/frame",
true
);
-loader.lazyRequireGetter(this, "throttle", "devtools/shared/throttle", true);
loader.lazyRequireGetter(
this,
"HighlighterEnvironment",
diff --git a/js/src/frontend/BytecodeEmitter.h b/js/src/frontend/BytecodeEmitter.h
--- a/js/src/frontend/BytecodeEmitter.h
+++ b/js/src/frontend/BytecodeEmitter.h
@@ -15,6 +15,7 @@
#include "mozilla/Span.h" // mozilla::Span
#include "mozilla/Vector.h" // mozilla::Vector
+#include <functional> // std::function
#include <stddef.h> // ptrdiff_t
#include <stdint.h> // uint16_t, uint32_t
diff --git a/memory/replace/phc/PHC.cpp b/memory/replace/phc/PHC.cpp
--- a/memory/replace/phc/PHC.cpp
+++ b/memory/replace/phc/PHC.cpp
@@ -91,7 +91,6 @@
#include "mozilla/XorShift128PlusRNG.h"
using namespace mozilla;
-using namespace mozilla::recordreplay;
//---------------------------------------------------------------------------
// Utilities
@@ -327,16 +326,16 @@ class GAtomic {
// The current time. Relaxed semantics because it's primarily used for
// determining if an allocation can be recycled yet and therefore it doesn't
// need to be exact.
- static Atomic<Time, Relaxed, Behavior::DontPreserve> sNow;
+ static Atomic<Time, Relaxed> sNow;
// Delay until the next attempt at a page allocation. See the comment in
// MaybePageAlloc() for an explanation of why it is a signed integer, and why
// it uses ReleaseAcquire semantics.
- static Atomic<Delay, ReleaseAcquire, Behavior::DontPreserve> sAllocDelay;
+ static Atomic<Delay, ReleaseAcquire> sAllocDelay;
};
-Atomic<Time, Relaxed, Behavior::DontPreserve> GAtomic::sNow;
-Atomic<Delay, ReleaseAcquire, Behavior::DontPreserve> GAtomic::sAllocDelay;
+Atomic<Time, Relaxed> GAtomic::sNow;
+Atomic<Delay, ReleaseAcquire> GAtomic::sAllocDelay;
// Shared, immutable global state. Initialized by replace_init() and never
// changed after that. replace_init() runs early enough that no synchronization
diff --git a/mozglue/baseprofiler/public/BaseProfiler.h b/mozglue/baseprofiler/public/BaseProfiler.h
--- a/mozglue/baseprofiler/public/BaseProfiler.h
+++ b/mozglue/baseprofiler/public/BaseProfiler.h
@@ -90,6 +90,7 @@
# include "mozilla/TimeStamp.h"
# include "mozilla/UniquePtr.h"
+# include <functional>
# include <stdint.h>
# include <string>
diff --git a/mozglue/misc/Mutex_windows.cpp b/mozglue/misc/Mutex_windows.cpp
--- a/mozglue/misc/Mutex_windows.cpp
+++ b/mozglue/misc/Mutex_windows.cpp
@@ -12,7 +12,7 @@
#include "MutexPlatformData_windows.h"
-mozilla::detail::MutexImpl::MutexImpl(recordreplay::Behavior aRecorded) {
+mozilla::detail::MutexImpl::MutexImpl() {
InitializeSRWLock(&platformData()->lock);
}
diff --git a/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp b/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
--- a/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
+++ b/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp
@@ -725,8 +725,7 @@ BackgroundHangMonitor::BackgroundHangMon
}
# endif
- if (!BackgroundHangManager::sDisabled && !mThread &&
- !recordreplay::IsMiddleman()) {
+ if (!BackgroundHangManager::sDisabled && !mThread) {
mThread =
new BackgroundHangThread(aName, aTimeoutMs, aMaxTimeoutMs, aThreadType);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment