Skip to content

Instantly share code, notes, and snippets.

@blademirage

blademirage/TechChallengeReview_99_20190910.md

Created September 10, 2019 11:18
Show Gist options
  • Save blademirage/5953916f1b664b926861c1ff0c5d63e6 to your computer and use it in GitHub Desktop.
Save blademirage/5953916f1b664b926861c1ff0c5d63e6 to your computer and use it in GitHub Desktop.
Download ZIP
Tech Challenge Review - 99 (2019-09-10)
Raw
TechChallengeReview_99_20190910.md

Considered this submission as a PASSED case.

Submitted tech challenge:

Pros Things we liked:

  • Detailed and correct documentations.
  • API endpoints naming follows problem statement.
  • Clean and tidy code.
  • Docker containers are running fine.
  • Demonstrated well use of existing frameworks/libraries.
  • Have both integration and unit tests.
  • All test cases can be executed successfully.

Cons Reasons why the submission fell short:

  • Consider to use the latest version of docker-compose file.

Secondary reasons:

  • N/A

Suggestions and Things that Can Be Improved:

  • N/A

Testing environment:

  • Droplet(instance) at DigitalOcean SGP1
  • Ubuntu 18.04 x64
  • Docker CE Client/Server v18.06.1-ce
  • Docker-Compose v1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment