Created
September 17, 2010 06:51
-
-
Save bxjx/583836 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var express = require('express'), | |
request = require('request'), | |
BufferList = require('bufferlist').BufferList, | |
sys = require('sys'); | |
var app = express.createServer( | |
express.logger(), | |
express.bodyDecoder() | |
); | |
app.get('/', function(req, res){ | |
if(req.param("url")) { | |
var url = unescape(req.param("url")); | |
var bl = new BufferList(); | |
request({uri:url, responseBodyStream: bl}, function (error, response, body) { | |
if (!error && response.statusCode == 200) { | |
var data_uri_prefix = "data:" + response.headers["content-type"] + ";base64,"; | |
var image = new Buffer(bl.toString(), 'binary').toString('base64'); | |
image = data_uri_prefix + image; | |
res.send('<img src="'+image+'"/>'); | |
} | |
}); | |
} | |
}); | |
app.listen(3010); |
Take a look at https://gist.github.com/804225
I ditched the external dependencies (BufferList
and request
) and was able to encode the image using only the standard HTTP
and URL
modules
While I'm curious what I was doing wrong, I'm happier with this approach. Let me know if you see any areas for improvement. Specifically, how I can skip the step of assembling the binary string and jump straight to converting it to base64.
this https://gist.github.com/1294667 should work fine
the current example above doesn't work due to dericated modules in the request
try by putting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm running 0.2.5 and get the same results whether using
body
orbl
. If I'm reading https://github.com/mikeal/request correctly,body
should be the value passed toresponseBodyStream
, right?Here's my experience: http://pastie.org/1513539
I've now discovered that a second
request
call will allow the script to work as expected. My first thought was "race condition" or "async issue", even though I couldn't see any issues, but I usingsetTimeout
s to delay the first request by 2 or 5 seconds didn't change anything.I'm pretty sure the issue is on my end (at least two other people are successful) and I don't want to burden you with debugging via gist. Any general pointers on narrowing down the issue, or docs to using/debugging Buffers & BufferLists would be appreciated.