Created
May 3, 2023 15:52
-
-
Save davidair/61a74614d546bc9d86b0bc7d3f5ed402 to your computer and use it in GitHub Desktop.
Fixing a build issue with slngen when .NET 8.0 is missing (based off faf0c43d8b6911881d7b8cf9bed7949636d00357 commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/Microsoft.VisualStudio.SlnGen.Tool/Microsoft.VisualStudio.SlnGen.Tool.csproj b/src/Microsoft.VisualStudio.SlnGen.Tool/Microsoft.VisualStudio.SlnGen.Tool.csproj | |
index cde9cbd..eeb9cee 100644 | |
--- a/src/Microsoft.VisualStudio.SlnGen.Tool/Microsoft.VisualStudio.SlnGen.Tool.csproj | |
+++ b/src/Microsoft.VisualStudio.SlnGen.Tool/Microsoft.VisualStudio.SlnGen.Tool.csproj | |
@@ -62,14 +62,6 @@ | |
ReferenceOutputAssembly="false" | |
SkipGetTargetFrameworkProperties="true" | |
TargetFramework="net7.0" /> | |
- <ProjectReference Include="..\Microsoft.VisualStudio.SlnGen\Microsoft.VisualStudio.SlnGen.csproj" | |
- SetTargetFramework="TargetFramework=net8.0" | |
- IncludeAssets="None" | |
- OutputItemType="SlnGenBuildOutput" | |
- PrivateAssets="All" | |
- ReferenceOutputAssembly="false" | |
- SkipGetTargetFrameworkProperties="true" | |
- TargetFramework="net8.0" /> | |
</ItemGroup> | |
<Target Name="CopySlnGenToOutputDirectoryAndPackage" | |
AfterTargets="PrepareForRun" | |
diff --git a/src/Microsoft.VisualStudio.SlnGen.UnitTests/Microsoft.VisualStudio.SlnGen.UnitTests.csproj b/src/Microsoft.VisualStudio.SlnGen.UnitTests/Microsoft.VisualStudio.SlnGen.UnitTests.csproj | |
index fb56477..7634cf7 100644 | |
--- a/src/Microsoft.VisualStudio.SlnGen.UnitTests/Microsoft.VisualStudio.SlnGen.UnitTests.csproj | |
+++ b/src/Microsoft.VisualStudio.SlnGen.UnitTests/Microsoft.VisualStudio.SlnGen.UnitTests.csproj | |
@@ -1,6 +1,6 @@ | |
<Project Sdk="Microsoft.NET.Sdk"> | |
<PropertyGroup> | |
- <TargetFrameworks>net472;netcoreapp3.1;net5.0;net6.0;net7.0;net8.0</TargetFrameworks> | |
+ <TargetFrameworks>net472;netcoreapp3.1;net5.0;net6.0;net7.0;</TargetFrameworks> | |
<IsPackable>false</IsPackable> | |
<NoWarn>$(NoWarn);SA1600</NoWarn> | |
</PropertyGroup> | |
diff --git a/src/Microsoft.VisualStudio.SlnGen/Microsoft.VisualStudio.SlnGen.csproj b/src/Microsoft.VisualStudio.SlnGen/Microsoft.VisualStudio.SlnGen.csproj | |
index 84b1a21..e393f6c 100644 | |
--- a/src/Microsoft.VisualStudio.SlnGen/Microsoft.VisualStudio.SlnGen.csproj | |
+++ b/src/Microsoft.VisualStudio.SlnGen/Microsoft.VisualStudio.SlnGen.csproj | |
@@ -1,7 +1,7 @@ | |
<Project Sdk="Microsoft.NET.Sdk"> | |
<PropertyGroup> | |
<OutputType>Exe</OutputType> | |
- <TargetFrameworks>net461;net472;netcoreapp3.1;net5.0;net6.0;net7.0;net8.0</TargetFrameworks> | |
+ <TargetFrameworks>net461;net472;netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks> | |
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.config</AllowedOutputExtensionsInPackageBuildOutputFolder> | |
<IncludeReferenceCopyLocalPathsInBuildOutputInPackage>true</IncludeReferenceCopyLocalPathsInBuildOutputInPackage> | |
<IsTool>true</IsTool> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment