Created
March 5, 2025 04:51
-
-
Save deepak1556/f3b4c8cae933321db8306a083208005f to your computer and use it in GitHub Desktop.
system-context-menu fired on non draggable regions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!DOCTYPE html> | |
<html> | |
<head> | |
<meta charset="UTF-8"> | |
<!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP --> | |
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'"> | |
<link href="style.css" rel="stylesheet"> | |
<title>Hello World!</title> | |
</head> | |
<body> | |
<h1>Hello World!</h1> | |
We are using Node.js <span id="node-version"></span>, | |
Chromium <span id="chrome-version"></span>, | |
and Electron <span id="electron-version"></span>. | |
<div id="draggable"></div> | |
<div id="separator"></div> | |
<div id="nondraggable"</div> | |
<!-- You can also require other files to run in this process --> | |
<script src="./renderer.js"></script> | |
</body> | |
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Modules to control application life and create native browser window | |
const { app, BrowserWindow, screen } = require('electron') | |
const path = require('node:path') | |
function createWindow () { | |
// Create the browser window. | |
const mainWindow = new BrowserWindow({ | |
width: 800, | |
height: 600, | |
frame: false, | |
webPreferences: { | |
preload: path.join(__dirname, 'preload.js') | |
} | |
}) | |
mainWindow.on('system-context-menu', (ev, point) => { | |
const {x , y} = screen.screenToDipPoint(point); | |
console.log('system-context-menu triggered', x, y) | |
}) | |
// and load the index.html of the app. | |
mainWindow.loadFile('index.html') | |
// Open the DevTools. | |
// mainWindow.webContents.openDevTools() | |
} | |
// This method will be called when Electron has finished | |
// initialization and is ready to create browser windows. | |
// Some APIs can only be used after this event occurs. | |
app.whenReady().then(() => { | |
createWindow() | |
app.on('activate', function () { | |
// On macOS it's common to re-create a window in the app when the | |
// dock icon is clicked and there are no other windows open. | |
if (BrowserWindow.getAllWindows().length === 0) createWindow() | |
}) | |
}) | |
// Quit when all windows are closed, except on macOS. There, it's common | |
// for applications and their menu bar to stay active until the user quits | |
// explicitly with Cmd + Q. | |
app.on('window-all-closed', function () { | |
if (process.platform !== 'darwin') app.quit() | |
}) | |
// In this file you can include the rest of your app's specific main process | |
// code. You can also put them in separate files and require them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | |
* This file is loaded via the <script> tag in the index.html file and will | |
* be executed in the renderer process for that window. No Node.js APIs are | |
* available in this process because `nodeIntegration` is turned off and | |
* `contextIsolation` is turned on. Use the contextBridge API in `preload.js` | |
* to expose Node.js functionality from the main process. | |
*/ | |
document.getElementById("nondraggable").addEventListener('contextmenu', (ev) => { | |
console.log('custom menu', ev.pageX, ev.pageY) | |
}) | |
document.getElementById("draggable").addEventListener('contextmenu', (ev) => { | |
console.log('custom menu', ev.pageX, ev.pageY) | |
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#draggable { | |
-webkit-app-region: drag; | |
width: 100px; | |
height: 100px; | |
background-color: red; | |
} | |
#separator { | |
width: 100px; | |
height: 20px; | |
} | |
#nondraggable { | |
width: 100px; | |
height: 100px; | |
background-color: blue; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Both system-context-menu and context menu events are firing for elements, even those marked as draggable. We need to ensure that:
✅ The context menu appears only for non-draggable elements
❌ The context menu does not appear for draggable elements
fixing Steps
update div elements properly
Add logic to block system context menu for draggable elements.
Update the create Window function with the following code:
Add logic to block system context menu for draggable elements.
Update the create Window function with the following code:
Add logic to block system context menu for draggable elements.
Update the create Window function with the following code:
Test the context menu behavior:
Right-click on nondraggable → Custom menu should appear.
Right-click on draggable → No context menu should appear.
End