Traits are often justified with a single, seductive argument:
“It makes the class look cleaner.”
Fewer lines. Less scrolling. A tidy façade.
This post explains why that argument is wrong—and why traits frequently increase complexity, coupling, and long-term maintenance cost, especially in PHP.
| <?php | |
| declare(strict_types=1); | |
| namespace Ghostwriter\Wip\Container\Ghostwriter\Config; | |
| use Ghostwriter\Config\Configuration; | |
| use Ghostwriter\Config\Interface\ConfigurationInterface; | |
| use Ghostwriter\Container\Interface\ContainerInterface; | |
| use Ghostwriter\Container\Interface\Service\ExtensionInterface; |
| <?php | |
| use Doctrine\DBAL\Connection; | |
| final class JoinMapping | |
| { | |
| /** | |
| * @param non-empty-string $idFieldAlias DB column alias for ID | |
| * @param array<non-empty-string, non-empty-string> $fieldMap alias => outputKey | |
| * @param array<non-empty-string, self> $children outputKey => mapping |
| <?php | |
| final class Deployment | |
| { | |
| /** | |
| * @param array<string, list<string>> $pipelineStages | |
| */ | |
| public function run(array $pipelineStages): void | |
| { | |
| $pipeline = new Fiber(function (array $pipelineStages): string { |
| <?php | |
| return [ | |
| 'dependencies' => [ | |
| 'factories' => [ | |
| 'BasicAuthMiddleware' => function (ContainerInterface $container): CustomAuthenticationMiddleware { | |
| $adapter = $container->get(BasicAuthAdapter::class); | |
| return new CustomAuthenticationMiddleware($adapter); | |
| }, | |
| 'OAuth2Middleware' => function (ContainerInterface $container): CustomAuthenticationMiddleware { |
| <?php | |
| interface Functor | |
| { | |
| /** | |
| * Maps a function over the functor. | |
| * | |
| * @template A | |
| * @template B | |
| * @param callable(A): B $f |
| # BlackLivesMatter | |
| name: Build & Test Extension | |
| on: | |
| push: | |
| pull_request: | |
| jobs: | |
| qa: | |
| runs-on: ubuntu-latest |
| (?(DEFINE) | |
| # Basic components | |
| (?<ALPHA>[A-Za-z]) | |
| (?<BIT>[01]) | |
| (?<DIGIT>[0-9]) | |
| (?<HEXDIG>[0-9A-Fa-f]) | |
| (?<CHAR>[\x01-\x7F]) | |
| (?<VCHAR>[\x21-\x7E]) | |
| (?<SP>[\x20]) | |
| (?<WSP>[\x20\x09]) |
| <?php | |
| /* | |
| Conflicts with file systems: :, *, ", <, >, | | |
| Conflicts with shell variables: $ | |
| Conflicts with bash brace expansion {, } | |
| */ |
| #!/bin/bash | |
| # GitHub username/organization | |
| USERNAME="ghostwriter" | |
| # Secret name and value | |
| SECRET_KEY="CODECOV_TOKEN" | |
| SECRET_VALUE="global-upload-token" | |
| # Get the list of repositories for the user |
