Created
December 1, 2024 00:25
-
-
Save jjeff/09dd58e289571d3956cc95ea92b7d73a to your computer and use it in GitHub Desktop.
Electron BaseWindow Custom Context Menu Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!DOCTYPE html> | |
<html> | |
<head> | |
<meta charset="UTF-8"> | |
<!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP --> | |
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'"> | |
<title>Hello World!</title> | |
</head> | |
<body> | |
<h1>Right-Click to Crash Me</h1> | |
<p>This is a BaseWindow with a WebContentsView. Context menus appear to crash it. Right-click to crash.</p> | |
We are using Node.js <span id="node-version"></span>, | |
Chromium <span id="chrome-version"></span>, | |
and Electron <span id="electron-version"></span>. | |
<!-- You can also require other files to run in this process --> | |
<script src="./renderer.js"></script> | |
</body> | |
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Modules to control application life and create native browser window | |
const { app, BaseWindow, WebContentsView, Menu } = require('electron') | |
const path = require('node:path') | |
function createWindow () { | |
// Create the browser window. | |
const mainWindow = new BaseWindow({ | |
width: 800, | |
height: 600, | |
}) | |
const mainView = new WebContentsView({ | |
webPreferences: { | |
preload: path.join(__dirname, 'preload.js') | |
} | |
}) | |
// and load the index.html of the app. | |
mainView.webContents.loadFile('index.html') | |
mainWindow.contentView.addChildView(mainView) | |
const {width, height} = mainWindow.getContentBounds() | |
mainView.setBounds({x: 0, y: 0, width, height}) | |
mainView.webContents.on('context-menu', (event, params) => { | |
event.preventDefault(); // Prevent the default context menu | |
showPopupMenu(mainWindow, params.x, params.y); | |
}) | |
// Open the DevTools. | |
// mainWindow.webContents.openDevTools() | |
} | |
function showPopupMenu(window, x, y) { | |
// Define the menu template | |
const menuTemplate = [ | |
{ | |
label: 'Option 1', | |
click: () => { | |
console.log('Option 1 clicked'); | |
window.webContents.send('menu-action', 'option-1'); | |
}, | |
}, | |
{ | |
label: 'Option 2', | |
click: () => { | |
console.log('Option 2 clicked'); | |
window.webContents.send('menu-action', 'option-2'); | |
}, | |
}, | |
{ type: 'separator' }, | |
{ | |
label: 'Quit', | |
role: 'quit', // Built-in role to quit the application | |
}, | |
]; | |
// Create the menu from the template | |
const menu = Menu.buildFromTemplate(menuTemplate); | |
// Show the menu at the specified position | |
menu.popup({ | |
window, | |
x, | |
y, | |
callback: () => { | |
console.log('Popup menu closed'); | |
}, | |
}); | |
} | |
// This method will be called when Electron has finished | |
// initialization and is ready to create browser windows. | |
// Some APIs can only be used after this event occurs. | |
app.whenReady().then(() => { | |
createWindow() | |
app.on('activate', function () { | |
// On macOS it's common to re-create a window in the app when the | |
// dock icon is clicked and there are no other windows open. | |
if (BrowserWindow.getAllWindows().length === 0) createWindow() | |
}) | |
}) | |
// Quit when all windows are closed, except on macOS. There, it's common | |
// for applications and their menu bar to stay active until the user quits | |
// explicitly with Cmd + Q. | |
app.on('window-all-closed', function () { | |
if (process.platform !== 'darwin') app.quit() | |
}) | |
// In this file you can include the rest of your app's specific main process | |
// code. You can also put them in separate files and require them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | |
"name": "ceaseless-support-camp-e5p5t", | |
"productName": "ceaseless-support-camp-e5p5t", | |
"description": "My Electron application description", | |
"keywords": [], | |
"main": "./main.js", | |
"version": "1.0.0", | |
"author": "Jeff Robbins", | |
"scripts": { | |
"start": "electron ." | |
}, | |
"dependencies": {}, | |
"devDependencies": { | |
"electron": "32.2.6" | |
} | |
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | |
* The preload script runs before `index.html` is loaded | |
* in the renderer. It has access to web APIs as well as | |
* Electron's renderer process modules and some polyfilled | |
* Node.js functions. | |
* | |
* https://www.electronjs.org/docs/latest/tutorial/sandbox | |
*/ | |
window.addEventListener('DOMContentLoaded', () => { | |
const replaceText = (selector, text) => { | |
const element = document.getElementById(selector) | |
if (element) element.innerText = text | |
} | |
for (const type of ['chrome', 'node', 'electron']) { | |
replaceText(`${type}-version`, process.versions[type]) | |
} | |
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | |
* This file is loaded via the <script> tag in the index.html file and will | |
* be executed in the renderer process for that window. No Node.js APIs are | |
* available in this process because `nodeIntegration` is turned off and | |
* `contextIsolation` is turned on. Use the contextBridge API in `preload.js` | |
* to expose Node.js functionality from the main process. | |
*/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment