Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Select an option

  • Save joseivanlopez/7ad52fd453c488846f9e941ddee8dc65 to your computer and use it in GitHub Desktop.

Select an option

Save joseivanlopez/7ad52fd453c488846f9e941ddee8dc65 to your computer and use it in GitHub Desktop.

We have detected some missing translations. There are two difference cases:

  • Strings marked for translations with N_ but then they are not translated with _. Example: src/components/storage/utils.ts#90 and src/components/storage/SpacePolicyMenu.tsx#45
  • Literal strings passed as component props without translations. Example: src/components/storage/SpaceActionsTable.tsx#153

FINDINGS

Case 1: Strings marked with N_() but not translated with _()

Space Policy Labels - MISSING TRANSLATION

File: src/components/storage/utils.ts

  • Line 90: N_("Delete current content") - NOT TRANSLATED
  • Line 94: N_("Shrink existing partitions") - NOT TRANSLATED
  • Line 98: N_("Use available space") - NOT TRANSLATED
  • Line 102: N_("Custom") - NOT TRANSLATED

Usage: These are in the SPACE_POLICIES array used in SpacePolicyMenu.tsx:45. The policy.label is rendered directly without translation.

Should be translated at: src/components/storage/SpacePolicyMenu.tsx:45 where {policy.label} should be {_(policy.label)}

Route Handles - PROPERLY TRANSLATED

All route names marked with N_() in route definitions are properly translated in src/components/layout/Sidebar.tsx:48

Registration Page Labels - PROPERLY TRANSLATED

All labels in src/components/product/ProductRegistrationPage.tsx (lines 64-67) are properly translated where used

WiFi Security Options - PROPERLY TRANSLATED

Options in src/components/network/WifiConnectionForm.tsx (lines 43-45) are properly translated at line 166

iSCSI Node Startup Options - PROPERLY TRANSLATED

Options in src/components/storage/iscsi/NodeStartupOptions.js (lines 26-28) are properly translated in multiple components

DASD Filter Options - PROPERLY TRANSLATED

Options in src/components/storage/dasd/FormatFilter.tsx and StatusFilter.tsx are properly translated

Filesystem Names - PROPERLY TRANSLATED

All filesystem names in src/components/storage/utils.ts (lines 66-82) are properly translated in the filesystemLabel function at line 325

⚠️ Size Units - EXPORTED BUT NOT USED

SIZE_UNITS in src/components/storage/utils.ts (lines 58-62) contains N_() marked strings but the constant is exported and never accessed with bracket notation, so these are likely not displayed anywhere.


Case 2: Literal strings passed as component props without translations

SpaceActionsTable.tsx - 3 instances

File: src/components/storage/SpaceActionsTable.tsx

  • Line 153: text="Do not modify" (ToggleGroupItem prop)
  • Line 159: text="Allow shrink" (ToggleGroupItem prop)
  • Line 166: text="Delete" (ToggleGroupItem prop)

IpSettingsForm.tsx - 1 instance

File: src/components/network/IpSettingsForm.tsx

  • Line 184: label="Gateway" (FormGroup prop)

EditNodeForm.tsx - 2 instances

File: src/components/storage/iscsi/EditNodeForm.tsx

  • Line 52: label="Startup" (FormGroup prop)
  • Line 55: aria-label="startup" (FormSelect prop - lowercase, likely technical ID)

DnsDataList.tsx - 1 instance

File: src/components/network/DnsDataList.tsx

  • Line 125: aria-label="DNS data list" (DataList prop)

Storage Pages - SelectList aria-labels - 3 instances

File: src/components/storage/PartitionPage.tsx

  • Line 589: aria-label="Available file systems" (SelectList prop)

File: src/components/storage/FormattableDevicePage.tsx

  • Line 309: aria-label="Available file systems" (SelectList prop)

File: src/components/storage/LogicalVolumePage.tsx

  • Line 485: aria-label="Available file systems" (SelectList prop)

SUMMARY

Case 1 (N_() without _()): 1 critical issue found

  • Space Policy Labels in SpacePolicyMenu.tsx need translation

Case 2 (Untranslated literals): 10 instances found across 7 files

  • 3 in SpaceActionsTable.tsx
  • 1 in IpSettingsForm.tsx
  • 2 in EditNodeForm.tsx
  • 1 in DnsDataList.tsx
  • 3 in Storage pages (PartitionPage, FormattableDevicePage, LogicalVolumePage)

Total missing translations: 11 instances (1 from Case 1 + 10 from Case 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment