liseferguson · November 8, 2018 23:09
diff --git a/gistfile1.txt b/gistfile1.txt
 1.) Add some explanatory text next to title search button
 2.) It might be a little cleaner if the browse all libraries, search for a book, and edit profile items were always shown consistently in one place. It mostly felt weird on th edit profile page, having a browse all libraries button in the middle.
 3.) Weird html included in alert that pops up when a user hits "submit book" button.
 4.) Button to "view all libraries" doesn't work from profile page
 5.) Looking good! Creating and editing my profile worked great, and I was able to add and delete books. I like the styles too, especially the floaty buttons. The 'Browse All Libraries' buttons and 'Go' buttons didn't work for me. You could add a Back or Cancel button to the Edit Profile page, or a way to edit book titles if you want. I think that's all I've got.
 6.) I really like the project! I noticed a strange alert with html inside of it when Add book! Is selected without Entering a title. I'm not sure what you are doing front end wise if it's vanilla or React, etc. But a great way to handle this would be to leave Add book! clickable, but if the user clicks Add book! without Enter a title, the Add book! button becomes disabled and either an updated correct alert or some other ui indication of for requirement until text is added into the enter a title field. You could do something similar to what you have when Entering a title to Go search at a minimum.

 Visually, I like this style you are going with, one thing that might be considered for UI/UX is that when browsing through All libraries is that there is a lot of space taken up per user. You cannot See a given users library at once. It might be more scannable by adding a container around the user information separating it from their library.

 Creating less space between the text for Sally for ex: moving it to the left and having the library list to the right. may allow for an easier flow of view. Overall, the end points and routes seem to be working for me great. The only route bug I encountered was after selecting My profile and then selecting the Book Genie header to get back to ability to Browse All libraries, when selecting Browse All Libraries, it did not update and show them as it does on initial load. Which requires reloading the url and logging back in.

 Overall, sweet concept, routes, and work overall Lise!
	1.) Add some explanatory text next to title search button
	2.) It might be a little cleaner if the browse all libraries, search for a book, and edit profile items were always shown consistently in one place. It mostly felt weird on th edit profile page, having a browse all libraries button in the middle.
	3.) Weird html included in alert that pops up when a user hits "submit book" button.
	4.) Button to "view all libraries" doesn't work from profile page
	5.) Looking good! Creating and editing my profile worked great, and I was able to add and delete books. I like the styles too, especially the floaty buttons. The 'Browse All Libraries' buttons and 'Go' buttons didn't work for me. You could add a Back or Cancel button to the Edit Profile page, or a way to edit book titles if you want. I think that's all I've got.
	6.) I really like the project! I noticed a strange alert with html inside of it when Add book! Is selected without Entering a title. I'm not sure what you are doing front end wise if it's vanilla or React, etc. But a great way to handle this would be to leave Add book! clickable, but if the user clicks Add book! without Enter a title, the Add book! button becomes disabled and either an updated correct alert or some other ui indication of for requirement until text is added into the enter a title field. You could do something similar to what you have when Entering a title to Go search at a minimum.

	Visually, I like this style you are going with, one thing that might be considered for UI/UX is that when browsing through All libraries is that there is a lot of space taken up per user. You cannot See a given users library at once. It might be more scannable by adding a container around the user information separating it from their library.

	Creating less space between the text for Sally for ex: moving it to the left and having the library list to the right. may allow for an easier flow of view. Overall, the end points and routes seem to be working for me great. The only route bug I encountered was after selecting My profile and then selecting the Book Genie header to get back to ability to Browse All libraries, when selecting Browse All Libraries, it did not update and show them as it does on initial load. Which requires reloading the url and logging back in.

	Overall, sweet concept, routes, and work overall Lise!