Last active
October 10, 2024 16:33
-
-
Save manast/1185904 to your computer and use it in GitHub Desktop.
Accurate Javascript setInterval replacement
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function interval(duration, fn){ | |
var _this = this | |
this.baseline = undefined | |
this.run = function(){ | |
if(_this.baseline === undefined){ | |
_this.baseline = new Date().getTime() | |
} | |
fn() | |
var end = new Date().getTime() | |
_this.baseline += duration | |
var nextTick = duration - (end - _this.baseline) | |
if(nextTick<0){ | |
nextTick = 0 | |
} | |
_this.timer = setTimeout(function(){ | |
_this.run(end) | |
}, nextTick) | |
} | |
this.stop = function(){ | |
clearTimeout(_this.timer) | |
} | |
} |
In the first time,it wait double douration, there is the fixed version and with the args:
export function Interval(fn,duration,...args){
const _this = this;
this.baseline = undefined
this.run = function(flag){
if(_this.baseline === undefined){
_this.baseline = new Date().getTime() - duration
}
if (flag){
fn(...args);
}
const end = new Date().getTime();
_this.baseline += duration
let nextTick = duration - (end - _this.baseline);
if(nextTick<0){
nextTick = 0
}
console.log(nextTick);
_this.timer = setTimeout(function(){
_this.run(true)
}, nextTick)
}
this.stop = function(){
clearTimeout(_this.timer)
}
}
Great tool!
Might want to have a look at https://github.com/docjojo/Timers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This works for me. What I assume has happened was, you were trying to call this.interval.stop() inside fn(), but in this case _this.run() will keep executing and creating a new setTimeout and assigned to _this.timer. To counter this, I marked _this.run as undefined in _this.stop, and before the assignment for _this.timer in the _this.run, I check if _this.run is still defined.
I hope this works for other people as well... Please correct me if I'm wrong.