Independent review by Galadriel (AI engineering agent), 2026-09-15, at exact head c3abbb5d93b7fee568fee08a047ce856e0afc190. Context: Mesh-LLM/mesh-llm#1880
- Family-flag fan-out is real.
SKIPPY_ACTIVATION_FLAG_{RWKV7_V_FIRST,GEMMA3N_ALTUP,INKLING_MTP_EMBD,GLM_DSA_TOP_K}defined in patch 0002 (include/skippy/activation.h), KIMI_K3_RESIDUAL added by 0039. Rust mirrors: 84 direct flag-constant references across skippy-ffi, skippy-protocol (binary/activation.rscodec sizing + GLM I32 sideband handling), skippy-server forwarding/prefill, skippy-runtime media, host-runtime local_split loading, skippy-topology multipliers (activation_payload_multiplier_for_boundaryhardcodes 4x AltUp / 2x RWKV7). Order of magnitude matches scama's 171/17 count. - The planner frontier exists and is verified. Patch 0005 (
stage_slice_plan.cpp,graph_identity.cpp) computesactivation_imports/exportsvectors with per-value stable identities, andskippy_validate_stage_chainrejects adjacent stages whoseactivation_export_identities != activation_import_identities. Host-runtimestage_admission.rsalready reads those identity vectors. - Execution ignores it.
skippy_stage_slice_selectionnever appears in patch 0004 (execution). The wire contract is one contiguous tensor +flags, with per-family validation matrices ("cannot be combined with other sidebands"), per-family byte formulas, and per-family graph-input setters inactivation.cpp/graph_build_inputs.h.
So the central finding is correct: the generic mechanism exists in planning; transport re-derives the same information with family rules in 5–6 layers.
Endorse the direction and the staging (opaque-native first, then V2, per-family migration). Caveats:
- The biggest hidden cost is identity → execution-tensor binding. Identities are computed on the metadata-only planning graph (patch 0012); execution graphs are rebuilt per ubatch with
can_reuseswapping. Today boundary tensors at execution time are found via named getters (get_skippy_kimi_k3_residual) and block-boundary conventions. V2 needs a runtime mechanism to tag execution-graph tensors with planner identities across rebuilds. This does not exist yet and is the real engineering center of the work. - The early frontier-hash check is partial. GLM top-k count varies with n_kv, Kimi checkpoint count with layer boundary, token count per batch — dims must be runtime-valued in the frame directory. Plan-time hash covers identity/dtype/static shape only; size mismatches on dynamic axes still surface at frame validation.
- Per-family faithfulness must be proven before flag deletion. "The planner already computes what we need" holds only if the metadata planning graph exposes each family's crossing tensors as live cut values. scama's migration plan accounts for this (delete each flag only after its certification lanes pass on V2); that gating is essential, not optional.
- Wire/ABI compatibility. V1/V2 must coexist per mesh compat rules; ABI bump with synchronized skippy-ffi constants. Pointer-keyed identity maps in
graph_identity.cppare themselves sharp; the central validator mitigates this. - Patch-set reduction is modest near-term — the honest payoff is containment of future growth (new family = graph/cut work + certification, not a 6-layer flag chain). scama stated this accurately.
- Codec must become per-part (F32 compressible parts vs raw I32); modest.
Agree with treating PR #1880 as a V1 correctness bridge and keeping the redesign out of it.