Created
May 16, 2016 12:32
-
-
Save mkrautz/deb67218d41789725603cddfafbdb4b1 to your computer and use it in GitHub Desktop.
[BUG] Indentation bug in split view diffing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Subject: [BUG] Indentation bug in split view diffing | |
| From: Mikkel Krautz <[email protected]> | |
| To: [email protected] | |
| Hi, | |
| I just stumbled on a bug in the split diff view. | |
| See the attached bug.png for a visual explanation. | |
| The problem is that the indentation of a block in the split diff view | |
| is wrong. It doesn't match the actual indentation of that block as | |
| seen in a text editor, and also as seen in the unified diff view. | |
| The offending code is at: | |
| Unified view: | |
| https://github.com/mkrautz/mumble/commit/1b02b7e1b09d7a04c0ac9a3ce4f4e09688635403?diff=unified | |
| Split view (BUGGY): | |
| https://github.com/mkrautz/mumble/commit/1b02b7e1b09d7a04c0ac9a3ce4f4e09688635403?diff=split | |
| Thanks, | |
| Mikkel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attachment:
