Skip to content

Instantly share code, notes, and snippets.

View mtucker's full-sized avatar

Matt Tucker mtucker

View GitHub Profile
@mtucker
mtucker / pr-comments.md
Last active April 20, 2026 21:30 — forked from erickrawczyk/pr-comments.md
PR Comments with a Purpose

This is a set of ‘statuses’ that pull request comments must be marked with to help explain intent.

  • Change Requested: This must be fixed before merge.
  • Suggested Change: Not blocking, but I suggest we do it this way.
  • Potential Alternative: Presenting an alternative approach in order to invite discussion.
  • Nice to have: Would be great to fix eventually.
  • Personal Preference: I would do this, but you don’t have to.
  • Question: Point of clarification on the approach
  • For My Understanding A question to help me understand
DROP TABLE if exists d_date;
CREATE TABLE d_date
(
date_dim_id INT NOT NULL,
date_actual DATE NOT NULL,
epoch BIGINT NOT NULL,
day_suffix VARCHAR(4) NOT NULL,
day_name VARCHAR(9) NOT NULL,
day_of_week INT NOT NULL,