ViBiOh

GitHub Pull-Request Etiquette

The Team

• Coding is work. Reviewing is, also, work. The added value of the code resides in its usage. Code is used when merged, merged when reviewed. So keep in mind that reviewing is adding value.
• Every member of the team should have at least one dedicated time slot (two or more is healthier) during his regular working day to perform code reviews. For example, at the beginning of the day, before starting something else, take a tour of GitHub. In the same way, when coming back from lunch.
• To know what is waiting for a review, the Review Request can be helpful (but sometimes too noisy). Take time to configure your Notifications, it's worth it.
• Even if you are busy working on the next big thing, don't let others wait for you, ensure that everyone can work at their full potential.
• The team owns several projects and the whole team is notified when a pull-request is opened. Once a review has been started by s

pkafel

Kafka command line tools

List (not complete)

• zookeeper-server-start.sh - starting Zookeeper
• kafka-server-start.sh - start Kafka
• kafka-topics.sh - manage topics in Kafka
• kafka-console-producer.sh - script for sending messages to Kafka topic
• kafka-console-consumer.sh - script for consuming messages from Kafka topic
• kafka-run-class.sh - script for running different tools (list of tools can be found here)