Created
July 3, 2012 18:56
-
-
Save richievos/3041941 to your computer and use it in GitHub Desktop.
Github Enterprise gripes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Enterprise gripes: | |
==Pull requests== | |
* Can't stage/batch up comments | |
Sometimes a comment is just a note to myself, and/or when I'm going through a diff I later find something that makes my comment irrelevant. I want to be able to stage a bunch of comments, and publish them all at once. | |
* too chatty (solved by batching comments) | |
Every single comment sends an email. This is really annoying when you're making multiple comments on a single pull request. | |
* no multi-line (block) comments | |
Usually I want to comment on a series of lines in a commit, not a single one. | |
* Can't hide comments on the diff page after they've been added. | |
Once someone puts a bunch of comments on the diff page, it's basically unusable, because you can't see the diff anymore. | |
* If you push new commits (especially if you do a force push) comments on previous commits get dropped | |
Not sure all the situations this happens, but if I force push over a pull request, any comments on the previous commit disappear from the pull request. | |
* I'd kill for a "pull request merged" email | |
Right now we workaround this by always putting a "merged" comment in, but it's annoying there's no notification otherwise. | |
* The github pull request email should have the pull request URL at the top. | |
99% of the time I want the pull request's url _not_ the repo's url. | |
You can merge this Pull Request by running: | |
git pull https://github.com/foo/bar baz | |
Or you can view, comment on it, or merge it online at: | |
https://github.com/foo/bar/pull/51 | |
Becomes | |
You can view, comment on it, or merge it online at: | |
https://github.com/foo/bar/pull/51 | |
Or you can merge this Pull Request by running: | |
git pull https://github.com/foo/bar baz | |
* Pull requests should let you specify exactly who to subscribe to the pull. | |
Having a pull request auto email an entire org/team is nice, but not always appropriate. The fact that you can't specifically list out who to contact on a pull request makes people not want to join particular teams or have commit rights, because they end up getting spammed with a billion pull requests and pull request emails. | |
A use case is letting anyone have read/write access to our repo. Right now we can't do that, because it means everyone in the company gets spammed with every commit to our repo. I'd prefer the pull request UI to default the groups getting notified (default it to @committers or something), but let me change it. | |
Even better, I'd want to be able to configure the default notified list for a repo. | |
Minor gripes: | |
* The pull request UI is confusing. | |
The "This pull request can be automatically merged." and "Comment on this pull request" buttons are very eye catching, and the same color. At least for me, this leads to me always having to think about which one to click. | |
Also while I get the button position stays the same. When I click "Merge pull request" I always feel like the next button to click is "Close pull request". Its positioning so close to the merge area has led to me accidentally clicking the Close button. | |
==Management== | |
* I want teams that span organizations. | |
As an example, say I have 2 logically separate sets of code (users and orders), and each of those has 3 codebases associated with it (orders-client, orders-service, orders-admin-ui). For logical grouping purposes, I want to put those in 2 separate orgs (users and orders), however, the same people may be working on those 2 codebases (say the users-orders team). Right now I end up having to create 2 orgs, and duplicate teams in both. | |
This sounds hypothetical, but almost that exact use case happened to me last week. So now I had to just put everyone in the same org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment