Ruby refactoring exercise

gistfile1.rb

class Array
  def to_annotated_xml(root)
    output = "<#{root}>"

    each do |i|
      if i.is_a?(Fixnum)
        output << "<number>#{i}</number>"
      elsif i.is_a?(String)
        if i.match(/@/)
          output << "<email>#{i}</email>"
        else
          output << "<string>#{i}</string>"
        end
      else
        output << "<value>#{i}</value>"
      end
    end

    output << "</#{root}>"
  end
end

p [1, "Stephen", "[email protected]"].to_annotated_xml("person")

refactored.rb

class Object
  def to_annotated_xml
    "<value>#{self}</value>"
  end  
end

class String
  def to_annotated_xml
    tag = self.match(/@/) ? 'email' : 'string'
    "<#{tag}>#{self}</#{tag}>"
  end
end

class Fixnum
   def to_annotated_xml
    "<number>#{self}</number>"
  end
end

class Array
  def to_annotated_xml(root)
    output = "<#{root}>"

    each do |i|
      output << i.to_annotated_xml
    end

    output << "</#{root}>"
  end
end

p [1, "Stephen", "[email protected]"].to_annotated_xml("person")