Skip to content

Instantly share code, notes, and snippets.

@sagudev

sagudev/servo-bencher.md

Last active October 31, 2024 05:24
Show Gist options
  • Save sagudev/ae5492d21bad3821a4deae20db872f7a to your computer and use it in GitHub Desktop.
Save sagudev/ae5492d21bad3821a4deae20db872f7a to your computer and use it in GitHub Desktop.
Download ZIP
Servo bencher design document
Raw
servo-bencher.md

Servo Bencher

SIDE-NOTE: no benches should be run in MQ

SIDE-NOTE: all pushes to try should be done using mach try perf.

Ways of triggering bencher runs:

push: main (PR landed)

publish results using --branch=main on bencher (and github checks or maybe job summary; need aditional work in bencher to support it using adtitonal flag)

push: try in servo/servo

publish results using --branch=try on bencher and should not be parent of old try run (try runs are independent), base should be last common commit from main

report as github check

push: try in personal fork (when tokens are not set)

because not token is available here we cannot send results to bencher but we should still generate results like in servo/servo case

label: try-*

same as try push to servo/servo, but bencher should also generate comment on PR

(while user could also create try-labels personal fork, but this is not supported workflow so we will not cover it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment