fix ceph metrics

README.md

metric l_rgw_pubsub_push_pending

in http, it's implemented here

with amqp

check function send

• case ack_level == ack_level_t::None -> increase then decrease
• case y, increase before line amqp::publish_with_confirm (L216), decrease after check rc < 0
• case y false, increase before amqp::publish_with_confirm (L228), decrease after amqp::publish_with_confirm (???)

with kafka

check function send

• case ack_level == ack_level_t::None -> increase then decrease
• case y, increase before line kafka::publish_with_confirm (L302), decrease after check rc < 0
• case y false, increase before kafka::publish_with_confirm (L313), decrease after amqp::publish_with_confirm (???)

metric l_rgw_pubsub_push_failed

is implemented here

for both kafka and amqp you have to change the code a little (for both y and not y):

const auto rc = w.async_wait(yield);
if (perfcounter) perfcounter->dec(l_rgw_pubsub_push_pending);
return rc;

and

const auto rc =  w.wait();
if (perfcounter) perfcounter->dec(l_rgw_pubsub_push_pending);
return rc;

regarding l_rgw_pubsub_push_failed you will have to add it to the persistent case only when we give up on the notification