udacityandroid/Code snippet from MainActivity.java

Afandy1 · 2017-12-08T19:43:13Z

it is better to write
public void decrement (View view){
if (quantity<=1){
// show an error message as a Toast.
Toast.makeText(this,"You cannot have less than 1 coffe",Toast.LENGTH_SHORT).show();
return;
// Exit this method early because there is nothing left to do.
}
quantity=quantity-1;
displayQuantity(quantity);
}
because once first implement , the decrement method get minus and the number of coffees will get less than 0 .

razakadegoke · 2017-12-11T23:40:06Z

Why the "return;" make the method increment and decrement not go further
` public void increment(View view) {

    if (quantity == 100) {
        // Show an error message as a toast
        Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
        // Exit this method early because there's nothing left to do
        return;
    }
    quantity = quantity + 1;
    displayQuantity(quantity);

}

public void decrement(View view) {

    if (quantity == 1) {
        // Show an error message as a toast
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        // Exit this method early because there's nothing left to do
       return;
    }
    quantity = quantity - 1;
    displayQuantity(quantity);
}`

nineOneOnePawel · 2017-12-14T12:55:56Z

In question no.4 there is mistake as when you click answer quantity==100 it tells you to try again.
Only accepts the answer when you pick quantity<=100...

JamieBe · 2018-02-04T16:56:50Z

Works fine with me.

/**
* This method is called when the plus button is clicked.
* this is the increment method
*/
public void increment(View view) {
if (quantity >= 100){
//show an error message as a toast
Toast.makeText(this, "Mehr als 100 Tassen gibt es nicht", Toast.LENGTH_SHORT).show();
return;
}
quantity = quantity + 1;
display(quantity);
// TextView quantityTextView = (TextView) findViewById(R.id.quantity_text_view);
// quantityTextView.setText("" + quantity);
}

/**
 * This method is called when the minus button is clicked.
 * This is the decrement method
 */
public void decrement(View view) {
    if (quantity < 1){
        //show an error message as a toast
        Toast.makeText(this, "Weniger als 1 Tasse gibt es nicht", Toast.LENGTH_SHORT).show();
       return;
    }
    quantity = quantity - 1;
    display(quantity);
    //TextView quantityTextView = (TextView) findViewById(R.id.quantity_text_view);
    //quantityTextView.setText("" + quantity);
}

Anmar89 · 2018-03-02T16:56:11Z

public void increment(View view) {

    if (quantity == 100) {
        Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
        return;
    }
    quantity++;
    display(quantity);

}

/**
 * This method is called when the  minus button is clicked.
 */
public void decrement(View view) {
    if (quantity == 1) {
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        return;
    }
    quantity--;
    display(quantity);

mxacan · 2018-03-04T21:42:41Z

/**
* This method is called when the plus button is clicked.
*/
public void increment(View view) {
if(quantity>=0){
quantity = quantity + 1;
displayQuantity(quantity);}
if(quantity>=100){
quantity = 100;
displayQuantity(quantity);
}
}

/**
 * This method is called when the minus button is clicked.
 */
public void decrement(View view) {
    if(quantity<=100){
    quantity = quantity - 1;
    displayQuantity(quantity);}
    if(quantity<=0){
        quantity=0;
        displayQuantity(quantity);
    }
}

abdullah-alialdin · 2018-03-05T06:38:39Z

This my code and work well

/**
* This method is called when the plus button is clicked.
*/
public void increment(View view) {

    //to prevent the user adding more than 100 cups
    if (quantity > 99){
        //to display a toast message
        Context context = getApplicationContext();
        CharSequence text = "you cannot have more than 100 cups";
        int duration = Toast.LENGTH_SHORT;
        Toast toast = Toast.makeText(context, text, duration);
        toast.show();
        return;
    }
    else {quantity = quantity + 1;}
    displayQuantity(quantity);
}

/**
 * This method is called when the minus button is clicked.
 */
public void decrement(View view) {


    //to prevent the user adding less than 1 cup
    if (quantity < 2){
        //to display a toast message
        Context context = getApplicationContext();
        CharSequence text = "you cannot have less than 1 cups";
        int duration = Toast.LENGTH_SHORT;
        Toast toast = Toast.makeText(context, text, duration);
        toast.show();
        return;
    }
    else {quantity = quantity - 1;}
    displayQuantity(quantity);
}

Team31250 · 2018-03-05T07:27:25Z

use it for every solution

/**
* This method is called when the plus button is clicked.
*/
public void increment(View view) {
if (quantity >= 100) {
// Show an error message as a toast
Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
// Exit this method early because there's nothing left to do
return;
}
quantity = quantity + 1;
displayQuantity(quantity);
}

/**
 * This method is called when the minus button is clicked.
 */
public void decrement(View view) {
    if (quantity <= 1) {
        // Show an error message as a toast 
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        // Exit this method early because there's nothing left to do
        return;
    }
    quantity = quantity - 1;
    displayQuantity(quantity);
}

this is right code for any problem

badrddinb · 2018-03-07T16:16:02Z

DONE

waelhabbal · 2018-03-12T15:10:44Z

Hi ...
@RandomYogi has been noticed that quantity become "0" when rotate the phone ... seems that the class MainActivity re-create... can anyone explain the reason.. to try to avoid that

thanx

xbarakota · 2018-03-18T19:36:09Z

Done

louayeldin · 2018-03-19T07:38:54Z

Done

Rosariobc · 2018-03-31T17:39:09Z

Update: Solved!!! I forgot to import the toast widget!

I did the code correct, but toast is not resolved... how should I correct it? Thanks

Eduese · 2018-05-30T21:53:30Z

Going back to the quiz

eiadt · 2018-06-07T16:44:38Z

I used this method and it's OK:
`` public void increment(View view) {
if (quantity<=99) {
quantity = quantity + 1;
}else {
Toast.makeText(this, "You cannot have more than 100 cups", Toast.LENGTH_SHORT).show();
}
displayQuantity(quantity);

}

/**
 * this method is called when the - button is clicked
 */
public void decrement(View view) {


    if (quantity>=2) {
        quantity = quantity - 1;
    }else {
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
    }

    displayQuantity(quantity);

}

tooptooptoop · 2018-06-26T20:14:47Z

thanks

alothaimeen · 2018-07-14T19:45:32Z

I used this code and it works perfectly.

``
`

/**
 * This method is called when the plus button is clicked.
 */
public void increment(View view) {
    if (quantity < 100) quantity = quantity +1;
    else {
        // Show an error message as a toast
        Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
    }
    displayQuantity(quantity);

}
/**
 * This method is called when the minus button is clicked.
 */
public void decrement (View view) {
    if (quantity > 1) quantity = quantity -1;
    else {
        // Show an error message as a toast
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
    }
    displayQuantity(quantity);

}

`

m7oda11 · 2018-09-23T15:50:14Z

anyone can share the full java code ?

juanromo13 · 2019-01-19T21:45:48Z

i can use this solution?

public void decrement(View view) { if (quantity > 1) { quantity--; } else { Toast.makeText(this,"You cannot have less than 1 coffee",Toast.LENGTH_SHORT).show(); } displayQuantity(quantity); }

TGRBTRFLY · 2019-03-20T23:17:23Z

If someone is dumb enough to need a TOAST message telling them that they can't order less than 1 cup... they shouldn't be ordering hot drinks. 8P Just use: if (quantity > 0) --- see below

int quantity = 0;
/**
* This method is called when the minus button is clicked.
/
public void decrement(View view) {
if (quantity > 0)
quantity = quantity - 1;
displayQuantity(quantity);
}
/*
* This method is called when the plus button is clicked.
*/
public void increment(View view) {
if (quantity == 100) {
// Show error message as toast
Toast.makeText(this, "You cannot order more than 100 cups", Toast.LENGTH_SHORT).show();
return;
}
quantity = quantity + 1;
displayQuantity(quantity);
}

Well, I guess they could order toppings only, but if this were a real app I wouldn't use this layout anyway.

sslaia · 2019-05-29T17:12:10Z

The solution code has flaw if the quantity variable is initialised with 0 value, as some here have found out. Clicking on minus sign would make the number go down to smaller than 1 (even to minus). The solution is to set the initial quantity value to 1:
int quantity = 1;

NarFooZ · 2019-06-05T00:01:06Z

public void increment(View view) {
    if (quantity > 99){
        Context context = getApplicationContext();
        CharSequence text = "The maximum of Coffee cups is 100!";
        int duration = Toast.LENGTH_SHORT;
        Toast toast = Toast.makeText(context, text, duration);
        toast.show();
    }else{
        quantity = quantity + 1;
    }


    displayQuantity(quantity);
}

/**
 * This method is called when the minus button is clicked.
 */
public void decrement(View view) {
    if (quantity < 2){
        Context context = getApplicationContext();
        CharSequence text = "The minimum of Coffee cups is 1!";
        int duration = Toast.LENGTH_SHORT;
        Toast toast = Toast.makeText(context, text, duration);
        toast.show();
                }else{
        quantity = quantity - 1;
    }

    displayQuantity(quantity);
}

yaminebl · 2019-06-15T14:24:32Z

This is mine

     public void increment(View view) {
            if (quantity == 10) {
                Context context = getApplicationContext();
                CharSequence text = "You can't order more than 10";
                int duration = Toast.LENGTH_SHORT;
                Toast toastMessage = Toast.makeText(context, text, duration);
                toastMessage.show();
                return;
            }
            quantity = quantity + 1;
            displayQuantity(quantity);
        }

        public void decrement(View view) {
            if (quantity == 1) {
                Context context = getApplicationContext();
                CharSequence text = "You can't order less than 1";
                int duration = Toast.LENGTH_SHORT;
                Toast toastMessage = Toast.makeText(context, text, duration);
                toastMessage.show();
                return;
            }
            quantity = quantity - 1;
            displayQuantity(quantity);
        }

alb-noah · 2020-03-31T21:17:34Z

to solve this I preferred to use this code...
 if (quantity > 0) {
           quantity = quantity - 1;
        } else {
            Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        }
        displayQuantity(quantity);
this way solves the problem @tompad2, but as Katherine said, there are many ways of solving these issues

is better to give quantity variable =1
and make if statement start with 1
if (quantity >1 )
so you can't get less than 1 cup

YoussefNachit · 2020-04-17T04:22:04Z

here is another method ( I start with quantity=2)
public void increment (View view) {
if (quantity<100){
quantity++;
display(quantity);
} else {
Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
return;
}
}
public void decrement (View view) {

    if (quantity>=2){
        quantity--;
        display(quantity);
    } else {
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        return;
    }
}

Ghazali-Sufi · 2020-08-23T06:43:42Z

to solve this I preferred to use this code...
 if (quantity > 0) {
           quantity = quantity - 1;
        } else {
            Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
        }
        displayQuantity(quantity);
this way solves the problem @tompad2, but as Katherine said, there are many ways of solving these issues

i also solved this way:

if(quantity == 0){
Toast.makeText(MainActivity.this, "You can not have less than 1 cup of coffee", Toast.LENGTH_SHORT).show();
return;
}

instead of 1 i used 0 ===> Happy Coding

Ghazali-Sufi · 2020-08-23T06:44:52Z

i also solved this way:

if(quantity == 0){
Toast.makeText(MainActivity.this, "You can not have less than 1 cup of coffee", Toast.LENGTH_SHORT).show();
return;
}

instead of 1 i used 0 ===> Happy Coding

eng4flo · 2020-10-13T11:09:21Z

Hi ...
@RandomYogi has been noticed that quantity become "0" when rotate the phone ... seems that the class MainActivity re-create... can anyone explain the reason.. to try to avoid that

thanx

Isnt quantity set to 0?? If so... if you start to click decrement when app is just started it would be doing -1....or?

Hi, I think that will work well
//AS quantity =2
// increase quantity by 1
public void increment(View view) {

    if (quantity == 100) {
        quantity = 100;
        Toast toast = Toast.makeText(context, "It isn't available, Try again", Toast.LENGTH_SHORT);
        toast.show();
             } else {
        quantity = quantity + 1;
    }
    display(quantity);
}

// decrease quantity by 1
public void decrement(View view) {


    if (quantity == 1) {
        quantity = 1;
        Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
    } else {
        quantity -= 1;
    }
    display(quantity);
}

mixspark · 2021-03-21T09:53:49Z

nice code

sudhir72350999 · 2021-10-17T10:21:33Z

nice this is nice lecture

	/**
	* This method is called when the plus button is clicked.
	*/
	public void increment(View view) {
	if (quantity == 100) {
	// Show an error message as a toast
	Toast.makeText(this, "You cannot have more than 100 coffees", Toast.LENGTH_SHORT).show();
	// Exit this method early because there's nothing left to do
	return;
	}
	quantity = quantity + 1;
	displayQuantity(quantity);
	}

	/**
	* This method is called when the minus button is clicked.
	*/
	public void decrement(View view) {
	if (quantity == 1) {
	// Show an error message as a toast
	Toast.makeText(this, "You cannot have less than 1 coffee", Toast.LENGTH_SHORT).show();
	// Exit this method early because there's nothing left to do
	return;
	}
	quantity = quantity - 1;
	displayQuantity(quantity);
	}

udacityandroid/Code snippet from MainActivity.java

Afandy1 commented Dec 8, 2017

Uh oh!

razakadegoke commented Dec 11, 2017

Uh oh!

nineOneOnePawel commented Dec 14, 2017

Uh oh!

JamieBe commented Feb 4, 2018

Uh oh!

Anmar89 commented Mar 2, 2018

Uh oh!

mxacan commented Mar 4, 2018

Uh oh!

abdullah-alialdin commented Mar 5, 2018

Uh oh!

Team31250 commented Mar 5, 2018

Uh oh!

badrddinb commented Mar 7, 2018

Uh oh!

waelhabbal commented Mar 12, 2018

Uh oh!

xbarakota commented Mar 18, 2018

Uh oh!

louayeldin commented Mar 19, 2018

Uh oh!

Rosariobc commented Mar 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eduese commented May 30, 2018

Uh oh!

eiadt commented Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tooptooptoop commented Jun 26, 2018

Uh oh!

alothaimeen commented Jul 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m7oda11 commented Sep 23, 2018

Uh oh!

juanromo13 commented Jan 19, 2019

Uh oh!

TGRBTRFLY commented Mar 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

If someone is dumb enough to need a TOAST message telling them that they can't order less than 1 cup... they shouldn't be ordering hot drinks. 8P Just use: if (quantity > 0) --- see below

Uh oh!

sslaia commented May 29, 2019

Uh oh!

NarFooZ commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaminebl commented Jun 15, 2019

Uh oh!

alb-noah commented Mar 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YoussefNachit commented Apr 17, 2020

Uh oh!

Ghazali-Sufi commented Aug 23, 2020

Uh oh!

Ghazali-Sufi commented Aug 23, 2020

Uh oh!

eng4flo commented Oct 13, 2020

Uh oh!

mixspark commented Mar 21, 2021

Uh oh!

sudhir72350999 commented Oct 17, 2021

Uh oh!

Rosariobc commented Mar 31, 2018 •

edited

Loading

eiadt commented Jun 7, 2018 •

edited

Loading

alothaimeen commented Jul 14, 2018 •

edited

Loading

TGRBTRFLY commented Mar 20, 2019 •

edited

Loading

NarFooZ commented Jun 5, 2019 •

edited

Loading

alb-noah commented Mar 31, 2020 •

edited

Loading