Skip to content

Instantly share code, notes, and snippets.

View wallrj's full-sized avatar
🎹

Richard Wall wallrj

🎹
84 followers · 104 following
  • Bristol, England
  • 15:49 (UTC +01:00)
View GitHub Profile
@wallrj
wallrj / 6331-archaeology.md
Last active August 10, 2026 16:56
How cert-manager #6331 came to be: archaeology of the issuing controller's public-key-mismatch check (context for PR #9116)

How #6331 came to be: the issuing controller's public-key-mismatch check

Background for cert-manager/cert-manager#9116. The PR moves the "next private key does not match CSR public key" check above the failure handling in issuing.(*controller).ProcessItem. A fair question on the PR was: the comment above that block already says "If public key does not match, do nothing (requestmanager will handle this)" — so how did we ever reach a state where the controller does do something (fails the issuance) on a key mismatch?

Short answer: the check was never a gate in front of the failure branch. It

@wallrj
wallrj / readme.diff
Created October 9, 2024 13:24
--- /dev/fd/63 2024-10-09 14:24:07.930411339 +0100
+++ /dev/fd/62 2024-10-09 14:24:07.930411339 +0100
@@ -19,7 +19,7 @@
This is performed in a separate step to allow you to easily uninstall and reinstall cert-manager without deleting your installed custom resources.
```bash
-$ kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.16.0/cert-manager.crds.yaml
+$ kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.16.1/cert-manager.crds.yaml
```
@wallrj
wallrj / cert-manager.manifests.1.15.3-1.16.0.diff
Created October 3, 2024 14:35
--- /dev/fd/63 2024-10-03 15:33:59.648838157 +0100
+++ /dev/fd/62 2024-10-03 15:33:59.648838157 +0100
@@ -89,7 +89,7 @@
name: Issuer
type: string
- jsonPath: .spec.username
- name: Requestor
+ name: Requester
type: string
- jsonPath: .status.conditions[?(@.type=="Ready")].message
@wallrj
wallrj / community-operators-prod.diff
Created October 2, 2024 16:25
diff --git a/operators/cert-manager/1.15.2/bundle.Dockerfile b/operators/cert-manager/1.16.0-beta.0/bundle.Dockerfile
index ff869b9b6..7316ee339 100644
--- a/operators/cert-manager/1.15.2/bundle.Dockerfile
+++ b/operators/cert-manager/1.16.0-beta.0/bundle.Dockerfile
@@ -5,8 +5,8 @@ LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1
LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=cert-manager
-LABEL operators.operatorframework.io.bundle.channels.v1=stable,candidate
-LABEL operators.operatorframework.io.bundle.channel.default.v1=stable
@wallrj
wallrj / community-operators.diff
Created October 2, 2024 16:22
diff --git a/operators/cert-manager/1.15.2/bundle.Dockerfile b/operators/cert-manager/1.16.0-beta.0/bundle.Dockerfile
index ff869b9b6..7316ee339 100644
--- a/operators/cert-manager/1.15.2/bundle.Dockerfile
+++ b/operators/cert-manager/1.16.0-beta.0/bundle.Dockerfile
@@ -5,8 +5,8 @@ LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1
LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=cert-manager
-LABEL operators.operatorframework.io.bundle.channels.v1=stable,candidate
-LABEL operators.operatorframework.io.bundle.channel.default.v1=stable
@wallrj
wallrj / changes.diff
Last active October 1, 2024 13:53
Measure the memory reduction in cert-manager with WatchList + WatchListClient (enabled using KUBE_FEATURE_WatchListClient environment variable): https://github.com/cert-manager/cert-manager/pull/7315
diff -r -u /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7315.pII8tE0/measurements/before/cainjector-binary.memory /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7315.pII8tE0/measurements/after/cainjector-binary.memory
--- /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7315.pII8tE0/measurements/before/cainjector-binary.memory 2024-10-01 14:27:42.868515393 +0100
+++ /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7315.pII8tE0/measurements/after/cainjector-binary.memory 2024-10-01 14:28:57.217698454 +0100
@@ -1,10 +1,10 @@
-VmPeak: 1279204 kB
-VmSize: 1279204 kB
+VmPeak: 1278436 kB
+VmSize: 1278436 kB
VmLck: 0 kB
VmPin: 0 kB
@wallrj
wallrj / cert-manager.manifests.1.15.3-1.16.0-beta.0.diff
Last active September 26, 2024 11:19
Looking at changes to the manifests in cert-manager 1.16. See https://github.com/jetstack/jetstack-charts/pull/359
--- /dev/fd/63 2024-09-26 12:16:45.377345201 +0100
+++ /dev/fd/62 2024-09-26 12:16:45.377345201 +0100
@@ -89,7 +89,7 @@
name: Issuer
type: string
- jsonPath: .spec.username
- name: Requestor
+ name: Requester
type: string
- jsonPath: .status.conditions[?(@.type=="Ready")].message
@wallrj
wallrj / changes.diff
Last active September 24, 2024 13:04
Measure the memory reduction in cert-manager with WatchList + ClientWatchList: https://github.com/cert-manager/cert-manager/pull/7175
diff -r -u /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7175.4HZhPg2/measurements/before/cainjector-binary.memory /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7175.4HZhPg2/measurements/after/cainjector-binary.memory
--- /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7175.4HZhPg2/measurements/before/cainjector-binary.memory 2024-09-24 12:55:00.352591089 +0100
+++ /home/richard/projects/cert-manager/cert-manager/out.test.cert-manager.7175.4HZhPg2/measurements/after/cainjector-binary.memory 2024-09-24 12:56:18.791011687 +0100
@@ -1,12 +1,12 @@
-VmPeak: 1278180 kB
-VmSize: 1278180 kB
+VmPeak: 1278184 kB
+VmSize: 1278184 kB
VmLck: 0 kB
VmPin: 0 kB
@wallrj
wallrj / test.cert-manager-PR-7291.sh
Last active September 20, 2024 13:54
https://github.com/cert-manager/cert-manager/pull/7291
#!/usr/bin/env bash
#
# https://github.com/cert-manager/cert-manager/pull/7291
#
# Creates a Kind cluster and installs cert-manager from master and then from the
# bug fix branch containing the fix.
#
# The logs are printed in each case to demonstrate that there are
# repeating errors in the master branch, and fewer errors in the bug fix
# branch.
@wallrj
wallrj / test.cert-manager-PR-7259.sh
Created September 6, 2024 16:27
https://github.com/cert-manager/cert-manager/pull/7259
#!/usr/bin/env bash
#
# https://github.com/cert-manager/cert-manager/pull/7259
#
# Creates a Kind cluster and installs cert-manager from master and then from the
# bug fix branch containing the fix.
#
# The logs are printed in each case to demonstrate that there are rapid
# repeating errors in the master branch, and only 2-3 errors in the bug fix
# branch.